OneSizeFitsQuorum commented on PR #1151: URL: https://github.com/apache/ratis/pull/1151#issuecomment-2357393946
Hi, @szetszwo @133tosakarin , 1. Maybe we need to create a new one for [sender](https://github.com/apache/ratis/blob/master/ratis-server/src/main/java/org/apache/ratis/server/storage/FileChunkReader.java#L59) as we already saw that the reset on the receiver side can sometimes fail, and there is no significant performance cost to creating a new digester? 2. Thanks for the reminder. Now that we have synchronized, we probably don't need to add another judgment; adding volatile would cause a sonar bug. Maybe we can undo this change. 3. It seems the ci failure is same as this problem discussed in [mail list](https://lists.apache.org/thread/m4r34p2y79z4rvy5vyc983ty06xxt92x), then we can merge this pr first and create a new issue for this problem for master. <img width="1919" alt="image" src="https://github.com/user-attachments/assets/afd4dd7c-9901-4ebb-a696-fddf73b5aaa7";> -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
