[ 
https://issues.apache.org/jira/browse/RATIS-2174?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17889906#comment-17889906
 ] 

yuuka commented on RATIS-2174:
------------------------------

[~szetszwo] , what do you think about?

> Move future.join outside the lock
> ---------------------------------
>
>                 Key: RATIS-2174
>                 URL: https://issues.apache.org/jira/browse/RATIS-2174
>             Project: Ratis
>          Issue Type: Wish
>    Affects Versions: 3.1.0, 3.1.1
>            Reporter: yuuka
>            Assignee: yuuka
>            Priority: Major
>
>  
> In RATIS-2162, we solved a deadlock problem, but after observing for a few 
> days, there may still be potential deadlock problems elsewhere.
>  
> The main reason for deadlock is to hold a lock and wait for a future.
>  
> So I suggest waiting for the future outside the lock as much as possible, 
> which should avoid deadlocks
>  
> Currently, I found that calling *changeToFollower* in the following functions 
> causes the above situation:
>  # RaftServerImpl.appendEntries
>  # RaftServerImpl.RequestVote
>  # checkAndInstallSnapshot



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

Reply via email to