133tosakarin commented on PR #1168: URL: https://github.com/apache/ratis/pull/1168#issuecomment-2418630380
> @133tosakarin , thanks a lot for working on this! The idea is great. > > * We should avoid using `Optional`. Using `final` is better since the compiler will enforce that the variable must be initialized before use. > * Let's pass an `AtomicBoolean` instead of adding the new `Pair` class. It will have much less code change. > > See https://issues.apache.org/jira/secure/attachment/13072253/1168_review.patch Sze, thank you for your advice! Our current commit is to move future.join out of the lock, but **OneSizeFitsQuorum** thinks there may be concurrency issues. What do you think? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
