jianghuazhu commented on PR #1172:
URL: https://github.com/apache/ratis/pull/1172#issuecomment-2448906875
> @jianghuazhu , thanks a lot for working on this!
>
> `TestRaftWithGrpc` failed in the previous run. Let's rerun it.
>
> BTW, please see if you have time to fix the remaining zero-copy bugs. We
may enable advanced tracing as below and rerun the test until it fails. Then,
check the retain-release trace to see why an object is released properly.
>
> ```diff
> +++
b/ratis-grpc/src/test/java/org/apache/ratis/grpc/MiniRaftClusterWithGrpc.java
> @@ -52,7 +52,7 @@ public class MiniRaftClusterWithGrpc extends
MiniRaftCluster.RpcBase {
>
> static {
> // TODO move it to MiniRaftCluster for detecting non-gRPC cases
> - ReferenceCountedLeakDetector.enable(false);
> + ReferenceCountedLeakDetector.enable(true);
> }
> ```
Thanks @szetszwo for the comment and review.
I will try to fix the `TestRaftWithGrpc` test failure and I will create a
new jira later.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
