[ 
https://issues.apache.org/jira/browse/RATIS-2189?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17900132#comment-17900132
 ] 

Tsz-wo Sze commented on RATIS-2189:
-----------------------------------

bq ... The USED_DIRECT_MEM issue only happens when using Streaming.  ...

[~ivanandika], Thanks for checking.   As you probably already known, there was 
a memory leak; see RATIS-2197.  Could you testing it with RATIS-2197?

bq. ...  ratis streaming can support backpressure feature, ...

[~Symious], That's a great idea!  We should support it.

> Use ByteBufAllocator#ioBuffer in NettyDataStreamUtils
> -----------------------------------------------------
>
>                 Key: RATIS-2189
>                 URL: https://issues.apache.org/jira/browse/RATIS-2189
>             Project: Ratis
>          Issue Type: Improvement
>          Components: Streaming
>            Reporter: Ivan Andika
>            Assignee: Ivan Andika
>            Priority: Minor
>             Fix For: 3.2.0
>
>          Time Spent: 20m
>  Remaining Estimate: 0h
>
> Currently, NettyDataStreamUtils uses ByteBufAllocator#directBuffer which 
> forces all ByteBufAllocator to allocate direct buffer even forĀ 
> PreferHeapByteBufAllocator (e.g. when we set 
> -Dorg.apache.ratis.thirdparty.io.netty.noPreferDirect=true).
> It's better to use ioBuffer and delegates to the actual ByteBufAllocator to 
> the type of memory it will use.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

Reply via email to