szetszwo opened a new pull request, #1198:
URL: https://github.com/apache/ratis/pull/1198
See RATIS-2225
```java
//RaftServerImpl.submitClientRequestAsync
try {
assertLifeCycleState(LifeCycle.States.RUNNING);
} catch (ServerNotReadyException e) {
final RaftClientReply reply = newExceptionReply(request, e);
requestRef.release();
return CompletableFuture.completedFuture(reply);
}
```
In the code above,
- it may catch `ServerNotReadyException` when the server is shutting down.
- It calls `newExceptionReply` which may throw another exception.
Then, requestRef.release() is not called.
Also, when a unchecked exception is thrown, it won't be logged.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
