szetszwo commented on code in PR #1204:
URL: https://github.com/apache/ratis/pull/1204#discussion_r1901182843
##########
ratis-server-api/src/main/java/org/apache/ratis/server/RaftServerConfigKeys.java:
##########
@@ -116,6 +116,21 @@ static void setStagingCatchupGap(RaftProperties
properties, int stagingCatchupGa
setInt(properties::setInt, STAGING_CATCHUP_GAP_KEY, stagingCatchupGap);
}
+ String BOOTSTRAP_TIMEOUT_KEY = PREFIX + ".bootstrap.timeout";
Review Comment:
Since we already have `staging.catchup.gap`, how about calling it
`staging.timeout`? It was unfortunate that we already used `staging` instead
of `bootstrap`.
##########
ratis-docs/src/site/markdown/configurations.md:
##########
@@ -104,6 +104,16 @@ When bootstrapping a new peer, If the gap between the
match index of the
peer and the leader's latest committed index is less than this gap, we
treat the peer as caught-up. Increase this number when write throughput is
high.
+---------------------------------------------------------------------------------
+| **Property** | `raft.server.bootstrap.timeout` |
+|:----------------|:------------------------------------|
+| **Description** | timeout of bootstrapping a new peer |
+| **Type** | TimeDuration |
+| **Default** | 3 times of timeoutMax |
Review Comment:
Thanks for updating the doc! Let's use the full name
`raft.server.rpc.timeout.max`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
