szetszwo commented on code in PR #1206:
URL: https://github.com/apache/ratis/pull/1206#discussion_r1902255725
##########
ratis-server/src/main/java/org/apache/ratis/server/impl/RaftServerImpl.java:
##########
@@ -1641,9 +1645,9 @@ leaderId, getMemberId(), currentTerm, followerCommit,
inconsistencyReplyNextInde
state.updateConfiguration(entries);
}
future.join();
+ final CompletableFuture<Void> appendLog = entries.isEmpty()?
appendLogFuture.get()
Review Comment:
@SzyWilliam , I see the problem now -- when it is empty, it should not wait
for the previous append. Otherwise, it blocks the heartbeats.
```java
final CompletableFuture<Void> appendLog = entries.isEmpty()?
CompletableFuture.completedFuture(null)
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
