szetszwo commented on code in PR #1215:
URL: https://github.com/apache/ratis/pull/1215#discussion_r1924435523
##########
ratis-server/src/main/java/org/apache/ratis/server/impl/RaftServerImpl.java:
##########
@@ -1717,7 +1717,7 @@ private long checkInconsistentAppendEntries(TermIndex
previous, List<LogEntryPro
}
// Check if "previous" is contained in current state.
- if (previous != null && !state.containsTermIndex(previous)) {
+ if (previous != null && !state.containsTermIndex(previous) &&
appendLogFuture.get().isDone()) {
Review Comment:
This will disable inconsistent check when the server is busy
(appendLogFuture.get().isDone() will mostly false). We need to remember the
entries being appended to the log; see
https://issues.apache.org/jira/secure/attachment/13074189/1215_review.patch
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
