szetszwo commented on code in PR #1213:
URL: https://github.com/apache/ratis/pull/1213#discussion_r1935123543
##########
build.sh:
##########
@@ -83,9 +83,9 @@ if [ ! -d "$DIR/build/apache-rat-${rat_version}" ]; then
tar zxf build/${filename} -C build/
fi
-echo "Running RAT license check"
+echo "Running RAT license check on $DIR"
output=$(java -jar
$DIR/build/apache-rat-${rat_version}/apache-rat-${rat_version}.jar -d $DIR -E
rat-excludes.txt)
-if [[ ! $(echo "$output" | grep '0 Unknown Licenses') ]]; then
+if [[ ! $(echo "$output" | grep '^0 Unknown Licenses') ]]; then
Review Comment:
I had 10 files generated in the `public` but passed the licenses check since
the command `grep '0 Unknown Licenses'` matched it.
```
10 Unknown Licenses
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
