szetszwo commented on code in PR #1218:
URL: https://github.com/apache/ratis/pull/1218#discussion_r1962265363
##########
ratis-server/src/main/java/org/apache/ratis/server/impl/StateMachineUpdater.java:
##########
@@ -263,7 +263,11 @@ private MemoizedSupplier<List<CompletableFuture<Message>>>
applyLog() throws Raf
final long incremented =
appliedIndex.incrementAndGet(debugIndexChange);
Preconditions.assertTrue(incremented == nextIndex);
if (f != null) {
- futures.get().add(f);
+ applyLogFutures = applyLogFutures.thenCombine(f.exceptionally(ex -> {
+ LOG.error("Exception while {}: applying txn index={}, nextLog={}",
this, nextIndex,
+ LogProtoUtils.toLogEntryString(entry));
+ return null;
+ }), (v, message) -> null);
Review Comment:
Both them are the same in our case. Separating them makes it more readable.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
