szetszwo commented on code in PR #1227:
URL: https://github.com/apache/ratis/pull/1227#discussion_r1966564639
##########
ratis-server/src/test/java/org/apache/ratis/TestReConfigProperty.java:
##########
@@ -196,13 +197,13 @@ public void testReconfigure() {
dummy.reconfigureProperty(PROP1, null);
dummy.startReconfiguration();
RaftTestUtil.waitFor(() -> dummy.getReconfigurationStatus().ended(),
100, 60000);
- Assert.assertEquals(PROP1 + "set to wrong value ", DEFAULT,
- dummy.getProperties().get(PROP1));
+ Assertions.assertEquals(DEFAULT
+, dummy.getProperties().get(PROP1), PROP1 + "set to wrong value ");
} catch (ReconfigurationException | IOException | InterruptedException |
TimeoutException e) {
exceptionCaught = true;
}
- Assert.assertFalse("received unexpected exception",
- exceptionCaught);
+ Assertions.assertFalse(
+ exceptionCaught, "received unexpected exception");
Review Comment:
Let's use `fail(..)` inside the catch-block instead of `assertFalse(..)`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
