slfan1989 commented on code in PR #1232:
URL: https://github.com/apache/ratis/pull/1232#discussion_r1978488204
##########
ratis-common/src/test/java/org/apache/ratis/BaseTest.java:
##########
@@ -112,8 +106,7 @@ public void assertNoFailures() {
ExitUtils.assertNotTerminated();
}
- // Retained to support junit 4 tests.
- @Rule
+ @RegisterExtension
Review Comment:
@szetszwo Apologies for the late response, and thank you very much for
reviewing this PR. The reason I made changes to this PR is that I noticed the
subclass TestRaftSnapshotWithGrpc of RaftSnapshotBaseTest is already using
JUnit5, while RaftSnapshotBaseTest is still using JUnit4. Therefore, I thought
it might be a good idea to update BaseTest to JUnit5 as well, but I may not
have fully considered the implications.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
