szetszwo commented on code in PR #1248:
URL: https://github.com/apache/ratis/pull/1248#discussion_r2051057331
##########
ratis-server/src/main/java/org/apache/ratis/server/impl/ServerImplUtils.java:
##########
@@ -138,19 +138,14 @@ synchronized Long getTerm(long index) {
synchronized void append(List<ConsecutiveIndices> entriesTermIndices) {
for(ConsecutiveIndices indices : entriesTermIndices) {
- // validate startIndex
- final Map.Entry<Long, ConsecutiveIndices> lastEntry = map.lastEntry();
- if (lastEntry != null) {
- Preconditions.assertSame(lastEntry.getValue().getNextIndex(),
indices.startIndex, "startIndex");
- }
map.put(indices.startIndex, indices);
Review Comment:
Let's assert that it won't overwrite a previous element.
```java
final ConsecutiveIndices previous = map.put(indices.startIndex,
indices);
Preconditions.assertNull(previous, "previous");
```
##########
ratis-server/src/main/java/org/apache/ratis/server/impl/ServerImplUtils.java:
##########
@@ -138,19 +138,14 @@ synchronized Long getTerm(long index) {
synchronized void append(List<ConsecutiveIndices> entriesTermIndices) {
for(ConsecutiveIndices indices : entriesTermIndices) {
- // validate startIndex
- final Map.Entry<Long, ConsecutiveIndices> lastEntry = map.lastEntry();
- if (lastEntry != null) {
- Preconditions.assertSame(lastEntry.getValue().getNextIndex(),
indices.startIndex, "startIndex");
- }
map.put(indices.startIndex, indices);
}
}
synchronized void removeExisting(List<ConsecutiveIndices>
entriesTermIndices) {
for(ConsecutiveIndices indices : entriesTermIndices) {
final ConsecutiveIndices removed = map.remove(indices.startIndex);
- Preconditions.assertSame(indices, removed, "removed");
+ Preconditions.assertSame(indices.startIndex, removed.startIndex,
"removed");
Review Comment:
Let's don't this. We want to make sure that they are the same object.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@ratis.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
