slfan1989 commented on PR #1257: URL: https://github.com/apache/ratis/pull/1257#issuecomment-2869215186
@szetszwo Could you please help review this PR? Thank you very much! Regarding the testAddNewFollowersNoSnapshot unit test.Before RATIS-2045, followers didn't sync snapshots from the leader. After applying RATIS-2045, followers will now sync snapshots from the leader. This change makes the original test assertion inaccurate. In my opinion, The new condition added by RATIS-2045 is reasonable. We should update the test's assertion to align with this behavior change. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
