szetszwo commented on code in PR #1267:
URL: https://github.com/apache/ratis/pull/1267#discussion_r2102955025
##########
ratis-examples/src/test/java/org/apache/ratis/examples/filestore/FileStoreStreamingBaseTest.java:
##########
@@ -136,7 +136,7 @@ private void testMultipleFiles(String pathBase, int
numFile, SizeInBytes fileLen
writerFutures.add(executor.submit(callable));
}
for (Future<FileStoreWriter> future : writerFutures) {
- future.get();
+ future.get().close();
Review Comment:
This is a good catch! A new client is created for each write, we should
close them.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
