leixm commented on code in PR #1285:
URL: https://github.com/apache/ratis/pull/1285#discussion_r2386940249


##########
ratis-netty/src/main/java/org/apache/ratis/netty/NettyRpcProxy.java:
##########
@@ -121,6 +125,17 @@ protected void channelRead0(ChannelHandlerContext ctx,
             future.complete(proto);
           }
         }
+
+        @Override
+        public void exceptionCaught(ChannelHandlerContext ctx, Throwable 
cause) {
+          failOutstandingRequests(new IOException("Caught an exception for the 
connection to " + peer, cause));
+          client.close();

Review Comment:
   ctx.close() and client.close() are equivalent and do not need to be called 
repeatedly.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@ratis.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to