szetszwo commented on code in PR #1281:
URL: https://github.com/apache/ratis/pull/1281#discussion_r2373123116
##########
ratis-server/src/test/java/org/apache/ratis/WatchRequestTests.java:
##########
@@ -302,7 +302,6 @@ static void checkAll(List<CompletableFuture<WatchReplies>>
watches, Logger log)
final WatchReplies watchReplies = watches.get(i).get(GET_TIMEOUT_SECOND,
TimeUnit.SECONDS);
final long logIndex = watchReplies.logIndex;
log.info("checkAll {}: logIndex={}", i, logIndex);
- final RaftClientReply watchAllReply = watchReplies.getAll();
Review Comment:
Just checked the code, it seems the reply won't be null since the future is
completed only if reply != null.
https://github.com/apache/ratis/blob/40539ece1dd582752b5ef104760ec0c84cdf9e33/ratis-client/src/main/java/org/apache/ratis/client/impl/UnorderedAsync.java#L86-L90
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
