[ 
https://issues.apache.org/jira/browse/RATIS-2375?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Ivan Andika updated RATIS-2375:
-------------------------------
    Description: 
Currently Transaction#cancelTransaction is not used although there is a TODO 
comment in RaftServerImpl regarding it.
{code:java}
    // TODO: this client request will not be added to pending requests until
    // later which means that any failure in between will leave partial state in
    // the state machine. We should call cancelTransaction() for failed requests
{code}
We might need to revisit this, maybe we need to use it to implement a rollback 
mechanism.

  was:
Currently Transaction#cancelTransaction is not used although there is a TODO 
comment in RaftServerImpl regarding it.

{code}
    // TODO: this client request will not be added to pending requests until
    // later which means that any failure in between will leave partial state in
    // the state machine. We should call cancelTransaction() for failed requests
{code}


We might need to revisit this.


> Use Transaction#cancelTransaction
> ---------------------------------
>
>                 Key: RATIS-2375
>                 URL: https://issues.apache.org/jira/browse/RATIS-2375
>             Project: Ratis
>          Issue Type: Improvement
>            Reporter: Ivan Andika
>            Priority: Major
>
> Currently Transaction#cancelTransaction is not used although there is a TODO 
> comment in RaftServerImpl regarding it.
> {code:java}
>     // TODO: this client request will not be added to pending requests until
>     // later which means that any failure in between will leave partial state 
> in
>     // the state machine. We should call cancelTransaction() for failed 
> requests
> {code}
> We might need to revisit this, maybe we need to use it to implement a 
> rollback mechanism.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

Reply via email to