szetszwo commented on code in PR #1331:
URL: https://github.com/apache/ratis/pull/1331#discussion_r2655738746
##########
ratis-server/src/main/java/org/apache/ratis/server/impl/ServerState.java:
##########
@@ -389,6 +389,7 @@ void setRaftConf(RaftConfiguration conf) {
if (!listeners.isEmpty()) {
server.getServerRpc().addRaftPeers(listeners);
}
+ server.checkAndUpdateListenerState().join();
Review Comment:
This setRaftConf(..) method is used by many cases including initRaftLog and
leader appendConfiguration. It is better to check listener in the
updateConfiguration(..) method.
BTW, there is another bug that we should also change
SnapshotInstallationHandler to call updateConfiguration(..) instead of
setRaftConf(..). Otherwise, the conf change will not be handled correctly.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
