[
https://issues.apache.org/jira/browse/RATIS-2389?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=18057143#comment-18057143
]
Xinyu Tan commented on RATIS-2389:
----------------------------------
[~taklwu]
> I am still getting up to speed on Ratis, but I want to clarify the scope of
> the retries you mentioned. Are we referring to sendRequestWithRetry (used by
> AsyncImpl#sendReadOnlyUnordered) or the operations governed by RetryPolicies?
> If so, should we address this as a follow-up task if time permits.
Yes, I was referring to the fact that the client might trigger retries for
various reasons, which could lead to an unexpected increase in latency. It
would be best to add detection for this within the Client span.
I have no further questions regarding the other parts.
Thanks for your patient replies! Looking forward to this feature!
> Implementing Opentelemetry Tracing in Apache Ratis
> --------------------------------------------------
>
> Key: RATIS-2389
> URL: https://issues.apache.org/jira/browse/RATIS-2389
> Project: Ratis
> Issue Type: New Feature
> Components: client, server
> Affects Versions: 3.3.0
> Reporter: Tak-Lon (Stephen) Wu
> Assignee: Tak-Lon (Stephen) Wu
> Priority: Minor
> Attachments: PoC-result-collected-spans.png,
> PoC-result-span-detail.png, PoC-result.png
>
>
> This proposal outlines the addition of OpenTelemetry support to Ratis. By
> instrumenting the full client-side request path, we can empower users and
> maintainers with the granular data necessary for both long-term performance
> optimization and proactive daily monitoring.
> * 1-pager proposal:
> [https://docs.google.com/document/d/1UKGVqOzkAXqUAJxOz1RHq6fIiO3xqV57eIqi-f9qdE4/edit?tab=t.0#heading=h.5a3u31wlm0n]
> * PoC: [https://github.com/taklwu/ratis/tree/opentelemetry0129]
> Subtasks
> * Define the Metadata Field: Modify RaftRpcMessage.proto to include an
> optional SpanContext field.
> * Add TraceUtil: Land the utility class in ratis-common based on the code
> you see in HBase.
> * Create the client span: Introduce the span supplier and CLIENT span hook.
> * Instrument GRPC on the Server: Start with the GRPC module as it is the
> most common transport. Instrument the onNext methods (or within the caller)
> to start/stop spans.
> * Come up with the user guide as part of the release.
>
> Preliminary results were captured by running filestore example.
> Reference
> 1. HBase Tracing with Opentelemetry, HBASE-22120
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
