ss77892 commented on PR #1339: URL: https://github.com/apache/ratis/pull/1339#issuecomment-3874046548
@szetszwo The workflow was following: 1. client send the request and it successfully pass the first check and lands to the RetryCache. 2. leadership changed 3. before landing the request to the log we find that we are not leader anymore and fail the request 4. OM wants to retry the request but it checks the RetryCache directly and tries to get the response. Since the request failed with an exception it fails with the NPE. HDDS-13621 adds the check that request from the cache is successful. If it's not the regular logic with retry will be triggered. So, from Ozone perspective the issue is already resolved. In other hand Ratis behavior is not consistent. Under similar circumstances (the leadership has been changed) the request might or might not be in the RetryCache, depending on the time when leadership has been changed. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
