slfan1989 commented on code in PR #1345:
URL: https://github.com/apache/ratis/pull/1345#discussion_r2790346484
##########
ratis-grpc/src/main/java/org/apache/ratis/grpc/client/GrpcClientProtocolClient.java:
##########
@@ -337,8 +348,15 @@ CompletableFuture<RaftClientReply>
onNext(RaftClientRequest request) {
if (f == null) {
return JavaUtils.completeExceptionally(new
AlreadyClosedException(getName() + " is closed."));
}
+ final RaftClientRequestProto proto;
+ try {
+ proto = toRaftClientRequestProto(request);
Review Comment:
Thanks for the review patch — I’ve already updated and improved the code
accordingly.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
