szetszwo commented on code in PR #1347:
URL: https://github.com/apache/ratis/pull/1347#discussion_r2805236251
##########
ratis-grpc/src/main/java/org/apache/ratis/grpc/server/GrpcServicesImpl.java:
##########
@@ -342,22 +343,46 @@ public void startImpl() {
@Override
public void closeImpl() throws IOException {
- for (Map.Entry<String, Server> server : servers.entrySet()) {
- final String name = getId() + ": shutdown server " + server.getKey();
- LOG.info("{} now", name);
- final Server s = server.getValue().shutdownNow();
- super.closeImpl();
+ InterruptedIOException interrupted = null;
+ try {
+ for (Map.Entry<String, Server> server : servers.entrySet()) {
+ final String name = getId() + ": shutdown server " + server.getKey();
+ LOG.info("{} now", name);
Review Comment:
Sorry that I kept this log in my previous comment. Let's don't print it
since it is not useful.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
