slfan1989 opened a new pull request, #1348:
URL: https://github.com/apache/ratis/pull/1348

   ## What changes were proposed in this pull request?
   
   ### Expected Behavior
   
   After detecting the stream is closed and reporting the error, the method 
should return immediately to avoid:
   - Creating unnecessary objects
   - Modifying state of a closed stream
   - Potential memory leaks and state inconsistencies
   
   ### Solution
   
   Add a `return` statement after the `responseError()` call at line 340.
   
   The same method already has correct error handling for group mismatch at 
line ~354, which includes a `return` statement after calling `responseError()`. 
The stream-closed check should follow the same pattern.
   
   ## What is the link to the Apache JIRA
   
   JIRA: RATIS-2407. Missing return statement after stream closed check in 
OrderedRequestStreamObserver.
   
   ## How was this patch tested?
   
   unit tests.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to