slfan1989 commented on PR #1354: URL: https://github.com/apache/ratis/pull/1354#issuecomment-3924097538
> @slfan1989 , thanks for working on this! > > * Let's add another parse(..) method to print out the conf key. > * Please update GrpcLogAppender and NettyClientStreamRpc. > > See the comments inlined and also https://issues.apache.org/jira/secure/attachment/13080872/1354_review.patch @szetszwo Thank you very much for taking the time to review code! I will carefully consider your suggestions and improve the relevant parts accordingly. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
