slfan1989 commented on PR #1356: URL: https://github.com/apache/ratis/pull/1356#issuecomment-3937964461
> @slfan1989 , Good catch that we should check if the ChannelFuture is success! > > Let's change the replies queue to a map (callId -> futrue). > > * Then, we can make sure that the reply must match the request. > * Also, we can support unordered replies in the future. > > See https://issues.apache.org/jira/secure/attachment/13080886/1356_review.patch @szetszwo Thank you so much for taking the time to review my code! Your suggestions were insightful and very helpful — I've already updated the code accordingly. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
