szetszwo commented on code in PR #1341: URL: https://github.com/apache/ratis/pull/1341#discussion_r2897468656
########## ratis-server/src/main/java/org/apache/ratis/server/impl/RaftServerImpl.java: ########## @@ -17,6 +17,7 @@ */ package org.apache.ratis.server.impl; +import io.opentelemetry.api.trace.Span; Review Comment: Sorry that I may not be clear in my last comment -- we should import io.opentelemetry only in ratis-common. Then, it will be easier to change the tracing dependency to be pluggable in the future. We often see that a library may introduce incompatible changes (such as Dropwizard Metrics v3 vs v4). Since Ratis itself is also a library, we don't want to force our consumer applications to use a particular dependency (e.g. Ratis supports both Dropwizard Metrics v3 and v4 by making it pluggable). Another reason is that a dependency may have CVEs (e.g. the infamous [Log4Shell](https://en.wikipedia.org/wiki/Log4Shell) case). Applications may choose to disable it. BTW, we should add a conf to enable/disable tracing. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
