adoroszlai opened a new pull request, #1404:
URL: https://github.com/apache/ratis/pull/1404

   ## What changes were proposed in this pull request?
   
   - `AbstractShell#close()` is never called, thus neither is `Command#close()`
   - No commands override the default no-op implementation of `Command#close()`.
   - `Context#close()` is only used to close `PrintStream`, which should be the 
responsibility of the creator of `Context`.  `System.out` does not need to be 
closed.
   
   Let's remove these unused and useless `close()` methods.
   
   https://issues.apache.org/jira/browse/RATIS-2469
   
   ## How was this patch tested?
   
   https://github.com/adoroszlai/ratis/actions/runs/23693045561


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to