[ 
https://issues.apache.org/jira/browse/RATIS-2469?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Attila Doroszlai resolved RATIS-2469.
-------------------------------------
    Fix Version/s: 3.3.0
       Resolution: Done

> Remove Command#close()
> ----------------------
>
>                 Key: RATIS-2469
>                 URL: https://issues.apache.org/jira/browse/RATIS-2469
>             Project: Ratis
>          Issue Type: Improvement
>          Components: shell
>            Reporter: Attila Doroszlai
>            Assignee: Attila Doroszlai
>            Priority: Major
>             Fix For: 3.3.0
>
>          Time Spent: 0.5h
>  Remaining Estimate: 0h
>
> - {{AbstractShell#close()}} is never called, thus neither is 
> {{Command#close()}}
> - No commands override the default no-op implementation of 
> {{Command#close()}}.
> - {{Context#close()}} is only used to close {{PrintStream}}, which should be 
> the responsibility of the creator of {{Context}}.  {{System.out}} does not 
> need to be closed.
> Let's remove these unused and useless {{close()}} methods.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

Reply via email to