HTHou commented on PR #1462: URL: https://github.com/apache/ratis/pull/1462#issuecomment-4514255822
Thanks for the review. Addressed the latest comments in 12dc7472: - Moved the TLS provider/protocol/cipher suite options up to TlsConf so they are not tied to GrpcTlsConfig. - Restored the MemoizedSupplier-based SslContext construction in GrpcFactory. - Removed GrpcTlsConfig.newBuilder(GrpcTlsConfig) and the test which only covered that helper. - Updated the JSSE-provider fallback test to call build() and expect SSLException. I also reran TestGrpcTlsConfig, checkstyle, spotbugs, and git diff --check. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
