adoroszlai opened a new pull request, #1470:
URL: https://github.com/apache/ratis/pull/1470

   ## What changes were proposed in this pull request?
   
   Fix warning about properties encoding:
   
   ```
   [INFO] --- resources:3.3.1:resources (default-resources) @ ratis-docs ---
   ...
   [INFO] The encoding used to copy filtered properties files have not been 
set. This means that the same encoding will be used to copy filtered properties 
files as when copying other filtered resources. This might not be what you 
want! Run your build with --debug to see which files might be affected. Read 
more at 
https://maven.apache.org/plugins/maven-resources-plugin/examples/filtering-properties-files.html
   ```
   
   by setting `propertiesEncoding` for `maven-resources-plugin` according to 
[doc](https://maven.apache.org/plugins/maven-resources-plugin/examples/filtering-properties-files.html).
   
   `ratis-version.properties` is read using `Properties` class, so encoding 
should be `ISO-8859-1`.
   
   
https://github.com/apache/ratis/blob/5217431ebfc70635c723871c897105050fcb1e7b/ratis-common/src/main/java/org/apache/ratis/util/VersionInfo.java#L100-L102
   
   https://issues.apache.org/jira/browse/RATIS-2441
   
   ## How was this patch tested?
   
   Warning is gone:
   https://github.com/adoroszlai/ratis/actions/runs/26450457188/job/77883526958


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to