szetszwo commented on code in PR #1481: URL: https://github.com/apache/ratis/pull/1481#discussion_r3422921077
########## ratis-common/src/main/java/org/apache/ratis/datastream/impl/DataStreamReplyByteBuf.java: ########## @@ -0,0 +1,174 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ +package org.apache.ratis.datastream.impl; + +import org.apache.ratis.proto.RaftProtos.CommitInfoProto; +import org.apache.ratis.proto.RaftProtos.DataStreamPacketHeaderProto.Type; +import org.apache.ratis.protocol.ClientId; +import org.apache.ratis.protocol.DataStreamPacket; +import org.apache.ratis.protocol.DataStreamReply; +import org.apache.ratis.protocol.DataStreamReplyHeader; +import org.apache.ratis.thirdparty.io.netty.buffer.ByteBuf; +import org.apache.ratis.thirdparty.io.netty.buffer.Unpooled; + +import java.util.Collection; +import java.util.Collections; +import java.util.Optional; +import java.util.concurrent.atomic.AtomicReference; + +/** + * Implements {@link DataStreamReply} with {@link ByteBuf}. + */ +public final class DataStreamReplyByteBuf extends DataStreamPacketImpl implements DataStreamReply { Review Comment: Similar to DataStreamPacketByteBuffer, Let's add a new DataStreamPacketByteBuf class. ########## ratis-common/src/main/java/org/apache/ratis/datastream/impl/DataStreamReplyByteBuf.java: ########## @@ -0,0 +1,174 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ +package org.apache.ratis.datastream.impl; + +import org.apache.ratis.proto.RaftProtos.CommitInfoProto; +import org.apache.ratis.proto.RaftProtos.DataStreamPacketHeaderProto.Type; +import org.apache.ratis.protocol.ClientId; +import org.apache.ratis.protocol.DataStreamPacket; +import org.apache.ratis.protocol.DataStreamReply; +import org.apache.ratis.protocol.DataStreamReplyHeader; +import org.apache.ratis.thirdparty.io.netty.buffer.ByteBuf; +import org.apache.ratis.thirdparty.io.netty.buffer.Unpooled; + +import java.util.Collection; +import java.util.Collections; +import java.util.Optional; +import java.util.concurrent.atomic.AtomicReference; + +/** + * Implements {@link DataStreamReply} with {@link ByteBuf}. + */ +public final class DataStreamReplyByteBuf extends DataStreamPacketImpl implements DataStreamReply { + public static final class Builder { Review Comment: Let's add a new DataStreamReplyBuilder class to share the code with DataStreamReplyByteBuffer.Builder. ########## ratis-common/src/main/java/org/apache/ratis/datastream/impl/DataStreamReplyByteBuf.java: ########## @@ -0,0 +1,174 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ +package org.apache.ratis.datastream.impl; + +import org.apache.ratis.proto.RaftProtos.CommitInfoProto; +import org.apache.ratis.proto.RaftProtos.DataStreamPacketHeaderProto.Type; +import org.apache.ratis.protocol.ClientId; +import org.apache.ratis.protocol.DataStreamPacket; +import org.apache.ratis.protocol.DataStreamReply; +import org.apache.ratis.protocol.DataStreamReplyHeader; +import org.apache.ratis.thirdparty.io.netty.buffer.ByteBuf; +import org.apache.ratis.thirdparty.io.netty.buffer.Unpooled; + +import java.util.Collection; +import java.util.Collections; +import java.util.Optional; +import java.util.concurrent.atomic.AtomicReference; + +/** + * Implements {@link DataStreamReply} with {@link ByteBuf}. + */ +public final class DataStreamReplyByteBuf extends DataStreamPacketImpl implements DataStreamReply { + public static final class Builder { + private ClientId clientId; + private Type type; + private long streamId; + private long streamOffset; + private ByteBuf buffer; + + private boolean success; + private long bytesWritten; + private Collection<CommitInfoProto> commitInfos; + + private Builder() { + } + + public Builder setClientId(ClientId clientId) { + this.clientId = clientId; + return this; + } + + public Builder setType(Type type) { + this.type = type; + return this; + } + + public Builder setStreamId(long streamId) { + this.streamId = streamId; + return this; + } + + public Builder setStreamOffset(long streamOffset) { + this.streamOffset = streamOffset; + return this; + } + + public Builder setBuffer(ByteBuf buffer) { + this.buffer = buffer; + return this; + } + + public Builder setSuccess(boolean success) { + this.success = success; + return this; + } + + public Builder setBytesWritten(long bytesWritten) { + this.bytesWritten = bytesWritten; + return this; + } + + public Builder setCommitInfos(Collection<CommitInfoProto> commitInfos) { + this.commitInfos = commitInfos; + return this; + } + + public Builder setDataStreamReplyHeader(DataStreamReplyHeader header) { + return setDataStreamPacket(header) + .setSuccess(header.isSuccess()) + .setBytesWritten(header.getBytesWritten()) + .setCommitInfos(header.getCommitInfos()); + } + + public Builder setDataStreamPacket(DataStreamPacket packet) { + return setClientId(packet.getClientId()) + .setType(packet.getType()) + .setStreamId(packet.getStreamId()) + .setStreamOffset(packet.getStreamOffset()); + } + + public DataStreamReplyByteBuf build() { + return new DataStreamReplyByteBuf( + clientId, type, streamId, streamOffset, buffer, success, bytesWritten, commitInfos); + } + } + + public static Builder newBuilder() { + return new Builder(); + } + + private final AtomicReference<ByteBuf> buffer; Review Comment: Let's rename it to buf for ByteBuf. It is easier to distinguish it with ByteBuffer. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
