adoroszlai opened a new pull request, #1491:
URL: https://github.com/apache/ratis/pull/1491

   ## What changes were proposed in this pull request?
   
   Make some minor improvements in `make_rc.sh`:
   * print actual release version, not snapshot one
   * check GPG key sooner
   * merge 3 loops over `*.tar.gz`
   * skip empty commit
   * fix typos
   
   https://issues.apache.org/jira/browse/RATIS-2570
   
   ## How was this patch tested?
   
   Before:
   
   ```
   Prepare release artifacts for Apache Ratis 3.3.0-SNAPSHOT
   ```
   
   After:
   
   ```
   Prepare release artifacts for Apache Ratis 0.0.1-ci-test
   ```
   
   Tested that creating two subsequent RCs does not add empty versioning 
commits:
   
   ```
   Prepare release artifacts for Apache Ratis 0.0.1-rc2
   ...
   ++ git commit -a -m '[RELEASE] Update version to 0.0.1'
   On branch release-0.0.1
   nothing to commit, working tree clean
   ++ echo '<version> up to date, nothing to commit'
   <version> up to date, nothing to commit
   ...
   HEAD is now at a8758c5f [RELEASE] Update version to 0.0.1
   ...
   ```
   
   `release` check in CI:
   https://github.com/adoroszlai/ratis/actions/runs/28117851656/job/83261844311
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to