szetszwo commented on code in PR #1494:
URL: https://github.com/apache/ratis/pull/1494#discussion_r3493018284


##########
pom.xml:
##########
@@ -402,6 +409,16 @@
         <artifactId>mockito-core</artifactId>
         <version>${mockito.version}</version>
       </dependency>
+      <dependency>
+        <groupId>net.bytebuddy</groupId>
+        <artifactId>byte-buddy</artifactId>
+        <version>${byte-buddy.version}</version>
+      </dependency>
+      <dependency>
+      <groupId>net.bytebuddy</groupId>
+        <artifactId>byte-buddy-agent</artifactId>
+        <version>${byte-buddy.version}</version>
+      </dependency>

Review Comment:
   Then, why need to add the byte-buddy dependencies?   For setting the 
versions?  It will bring them automatically.
   
   - Without byte-buddy dependencies
   ```
   [INFO] \- org.mockito:mockito-core:jar:4.11.0:test
   [INFO]    +- net.bytebuddy:byte-buddy:jar:1.12.19:test
   [INFO]    +- net.bytebuddy:byte-buddy-agent:jar:1.12.19:test
   [INFO]    \- org.objenesis:objenesis:jar:3.3:test
   ```
   
   - With byte-buddy dependencies
   ```
   [INFO] \- org.mockito:mockito-core:jar:4.11.0:test
   [INFO]    +- net.bytebuddy:byte-buddy:jar:1.18.10:test
   [INFO]    +- net.bytebuddy:byte-buddy-agent:jar:1.18.10:test
   [INFO]    \- org.objenesis:objenesis:jar:3.3:test
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to