fapifta opened a new pull request, #1511:
URL: https://github.com/apache/ratis/pull/1511

   ## What changes were proposed in this pull request?
   
   The TLS provider, protocol list, and cipher suites configured on a TlsConf 
were applied on the gRPC transport but ignored on the Netty DataStream 
transport, so the DataStream server and client always used the provider 
defaults.
   
   This adds a small helper in NettyUtils that applies those settings when 
building the SslContext, and calls it for both the server and client. Ciphers 
are applied through SupportedCipherSuiteFilter (rather than the gRPC path's 
IdentityCipherSuiteFilter) so that an unsupported or misspelled cipher is 
dropped instead of crashing the server. Nothing changes when these settings are 
left unset.
   
   Generated-by: Claude Code (Claude Opus 4.8)
   
   ## What is the link to the Apache JIRA
   
   https://issues.apache.org/jira/browse/RATIS-2598
   
   ## How was this patch tested?
   
   Added three tests to TestTlsConfWithNetty covering the real NettyUtils code 
path: one checks that a configured cipher actually ends up on the SslContext, 
one checks that an unsupported cipher is filtered out instead of failing the 
build, and one runs a full TLSv1.2 handshake with an explicit protocol and 
cipher list. All five tests in the class pass, and checkstyle is clean on the 
two changed modules.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to