peterxcli commented on code in PR #1516:
URL: https://github.com/apache/ratis/pull/1516#discussion_r3576153272
##########
ratis-netty/src/main/java/org/apache/ratis/netty/server/ReadStreamManagement.java:
##########
@@ -182,6 +199,22 @@ private boolean processImpl(DataStreamRequestByteBuf
requestBuf, ChannelHandlerC
return false;
}
+ if (readResolver != null) {
+ final StateMachine.DataApi dataApi;
+ try {
+ dataApi = readResolver.resolve(request);
+ } catch (Throwable t) {
+ replyDataStreamException(server, t, request, requestBuf, ctx);
Review Comment:
for example, the container is closed, it doesn't have the division anymore,
if the resolve process thrown exception, then the fallback to division would
just get the the `GroupMismatchException`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
