slfan1989 commented on PR #1445: URL: https://github.com/apache/ratis/pull/1445#issuecomment-5028335379
> Yup, let's wait for @slfan1989 to address the test failures Thanks @spacemonkd and @szetszwo. Since this PR is based on the old `RATIS-1931_grpc-zero-copy` branch, would it be okay to first complete the zero-copy migration onto the current `master`? Some parts of the old branch have diverged significantly from `master`, which may also cause compatibility issues and flaky test failures. Addressing these failures directly on the old branch may therefore require changes that will become obsolete after the migration. After the new branch is ready, I will reapply the RATIS-2512 fix there, rerun the relevant tests against the current codebase, and open a replacement PR. The migration approach is being discussed here: https://lists.apache.org/thread/n9h35mvqor5dl8vpdfnngvqjwl5bx133 I would appreciate your thoughts on whether this approach sounds reasonable before I proceed. Thanks! cc: @adoroszlai -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
