HTHou commented on code in PR #1561:
URL: https://github.com/apache/ratis/pull/1561#discussion_r3868548109
##########
ratis-grpc/src/main/java/org/apache/ratis/grpc/GrpcConfigKeys.java:
##########
@@ -293,6 +293,22 @@ static void setServicesCustomizer(Parameters parameters,
GrpcServices.Customizer
parameters.put(SERVICES_CUSTOMIZER_PARAMETER, customizer,
SERVICES_CUSTOMIZER_CLASS);
}
+ String TLS_HANDSHAKE_FAILURE_LISTENER_PARAMETER = PREFIX +
".tls.handshake.failure.listener";
+ Class<TlsHandshakeFailureListener> TLS_HANDSHAKE_FAILURE_LISTENER_CLASS =
+ TlsHandshakeFailureListener.class;
Review Comment:
Thanks for the suggestion. Updated in 058baf387: the parameter now stores a
generic `ServerCredentials` via `GrpcConfigKeys.Server.setCredentials(...)`,
and `GrpcServicesImpl` passes it directly to
`NettyServerBuilder.forAddress(...)`. The TLS listener is exposed through
`TlsHandshakeFailureServerCredentials.create(...)`, and the test registers that
implementation through the generic credentials configuration, so other
`ServerCredentials` implementations are supported as well.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
