slfan1989 commented on PR #1572: URL: https://github.com/apache/ratis/pull/1572#issuecomment-5484074546
@szetszwo Hi Tsz-Wo, the PR is ready now. It fixes the flaky `testStateMachineMetrics` by using the reply log index as the expected value and waiting with a bounded retry until both state machine metrics reach it, instead of asserting immediately after the request. I also made a minor cleanup to statically import `assertTrue`. Thanks for the review and the +1! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
