lugency opened a new pull request, #1575:
URL: https://github.com/apache/ratis/pull/1575

   ## What changes were proposed in this pull request?
   
   Replace the redundant `setFirstRequest()` call in 
`OrderedAsync#sendRequestWithRetry()` with an assertion. The first-request flag 
has already been set by `SlidingWindow$Client#sendOrDelayRequest()` before the 
request is constructed. The assertion verifies this invariant.
   
   This change also includes the first-request information in the corresponding 
log representations.
   
   ## What is the link to the Apache JIRA
   
   [RATIS-2677](https://issues.apache.org/jira/browse/RATIS-2677):
    In `OrderedAsync`, `setFirstRequest()` is not needed.
   
   ## How was this patch tested?
   
   Tested locally:
   
   - `TestRaftAsyncWithGrpc#testBasicAppendEntriesAsync`
   - `TestRaftAsyncWithGrpc#testBasicAppendEntriesAsyncKillLeader`


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to