HTHou commented on code in PR #1577: URL: https://github.com/apache/ratis/pull/1577#discussion_r3946421404
########## ratis-grpc/src/main/java/org/apache/ratis/grpc/server/GrpcLogAppender.java: ########## Review Comment: Addressed in the updated implementation. A stopped AppendLogResponseHandler now emits onAppendEntriesReset(error) before returning, without resetting the client or updating follower/leader state. The regression test covers both appender stop and leadership change with multiple pending requests, including a throwing listener. The extension now exposes generic per-appender lifecycle callbacks. Consumers correlate request IDs and deduplicate terminal outcomes; audit-specific filtering and aggregation are outside Ratis. The snapshot error path also releases its waiter when the appender has stopped. All 16 targeted tests pass. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
