[
https://issues.apache.org/jira/browse/RATIS-13?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15870859#comment-15870859
]
Tsz Wo Nicholas Sze commented on RATIS-13:
------------------------------------------
- The CodeInjectionForTesting changes in GRpcLogAppender and RaftServerImpl
should be reverted.
- We should not remove the following javadoc in RaftClient
{code}
- /** Set {@link RaftClient} ID. */
- public Builder setClientId(String clientId) {
+ public Builder setClientId(ClientId clientId)
{code}
+1 Patch looks good other than that.
> Add global unique ID for Raft Client
> ------------------------------------
>
> Key: RATIS-13
> URL: https://issues.apache.org/jira/browse/RATIS-13
> Project: Ratis
> Issue Type: Sub-task
> Reporter: Jing Zhao
> Assignee: Jing Zhao
> Attachments: RATIS-13.000.patch, RATIS-13.001.patch
>
>
> Similar idea as HADOOP-9688. But since we need to support various RPC
> engines, the client id is not added in the RPC layer but in the raft protocol
> layer.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
