[ 
https://issues.apache.org/jira/browse/RATIS-31?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15886923#comment-15886923
 ] 

Jing Zhao commented on RATIS-31:
--------------------------------

I think the {{base}} parameter can be kept and used to check if the generated 
class is a subclass of it. +1 after addressing this comment.

> Support customized RPC types
> ----------------------------
>
>                 Key: RATIS-31
>                 URL: https://issues.apache.org/jira/browse/RATIS-31
>             Project: Ratis
>          Issue Type: Sub-task
>            Reporter: Tsz Wo Nicholas Sze
>            Assignee: Tsz Wo Nicholas Sze
>         Attachments: r31_20170227b.patch, r31_20170227.patch
>
>
> This JIRA is to address [~jingzhao] comment in RATIS-28
> {quote}
> Maybe we should consider using RpcType as an internal util stuff instead of 
> exposing it in public interfaces, considering most library users will have to 
> integrate the Ratis library with their own RPC engine.
> {quote}



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Reply via email to