[
https://issues.apache.org/jira/browse/RATIS-22?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15888986#comment-15888986
]
Jing Zhao commented on RATIS-22:
--------------------------------
The patch looks good to me. Some minors:
# In "newLeader = RaftUtils.next(oldLeader, RaftUtils.as(peers, p ->
p.getId()))", p -> p.getId() can be further simplified as RaftPeer::getId.
# Maybe rename RaftClientRequestSender to RaftClientRpc, and do rename
accordingly for Hadoop/GRpc/Netty? We can do this in a separate jira.
+1 after addressing comments.
> Use a factory method to create RaftClientRequestSender
> ------------------------------------------------------
>
> Key: RATIS-22
> URL: https://issues.apache.org/jira/browse/RATIS-22
> Project: Ratis
> Issue Type: Sub-task
> Reporter: Tsz Wo Nicholas Sze
> Assignee: Tsz Wo Nicholas Sze
> Attachments: r22_20170216.patch, r22_20170227.patch
>
>
> Similar to ServerFactory, we should provide a ClientFactory to create
> RaftClientRequestSender objects. The ClientFactory implementation can be
> automatically deduced from the RpcType.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
