kaiyangzhang created RATIS-77:
---------------------------------

             Summary: "RaftServerProtocolService" and " GRpc.proto" not 
inconsistent
                 Key: RATIS-77
                 URL: https://issues.apache.org/jira/browse/RATIS-77
             Project: Ratis
          Issue Type: Bug
            Reporter: kaiyangzhang
            Assignee: Jing Zhao


*Maybe a bug, look at the comments in the code and GRpc.proto*



{code:title=GRpc.proto|borderStyle=solid}
   ......
   ......
   //Executes a client-streaming call , return only one response.
   rpc installSnapshot(stream ratis.common.InstallSnapshotRequestProto)
      returns(ratis.common.InstallSnapshotReplyProto) {}
   .......
   .......
{code}
{code:title=RaftServerProtocolService.java |borderStyle=solid}
    ........
    ........
    @Override
  public StreamObserver<InstallSnapshotRequestProto> installSnapshot(
      StreamObserver<InstallSnapshotReplyProto> responseObserver) {
    return new StreamObserver<InstallSnapshotRequestProto>() {
      @Override
      public void onNext(InstallSnapshotRequestProto request) {
        try {
          //receive a client-streaming call, return a response stream
          //code and GRpc.proto inconsistent
          final InstallSnapshotReplyProto reply = 
server.installSnapshot(request);
          responseObserver.onNext(reply);
        } catch (Throwable e) {
          LOG.info("{} got exception when handling installSnapshot {}: {}",
              id, request.getServerRequest(), e);
          responseObserver.onError(RaftGrpcUtil.wrapException(e));
        }
      }
   ..........
   ..........
{code}







--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Reply via email to