Elek, Marton created RATIS-102:

             Summary: Clean generated sources as part of the default clean 
                 Key: RATIS-102
                 URL: https://issues.apache.org/jira/browse/RATIS-102
             Project: Ratis
          Issue Type: Bug
            Reporter: Elek, Marton
            Assignee: Elek, Marton

RATIS-49 introduced new profiles to cleanup the generated sources/proto files 
in the shaded artifacts.

I suggest to make it more easier by binding the additional {clean:clean} plugin 
calls to the clean phase of the default clean lifecycle instead of trigger them 
from a separated profile.  

In RATIS-4 I experimenting  with build scripts and yetus test-patch script. As 
the simple {{mvn clean}} command is more common, it would be easier to switch 
to the simple clean without the profile.

The cleanup could be done with triggering additional clean plugin execution.

To test:
git checkout 52c4b64
mvn clean package -DskipTests
git checkout master
mvn clean package -DskipTests

Without the patch the second only works with -Pclean-shade, with the proposed 
patch it works without activating any additional profile

This message was sent by Atlassian JIRA

Reply via email to