[
https://issues.apache.org/jira/browse/RATIS-104?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16158256#comment-16158256
]
Tsz Wo Nicholas Sze commented on RATIS-104:
-------------------------------------------
Thanks Chen, the patch looks good. Some minor comments:
- Use ProtoUtils.toRaftGroupProtoBuilder and ProtoUtils.toRaftGroup in
ClientProtoUtils.
- In RaftClientImpl.serverInformation, add Objects.requireNonNull to check if
server == null.
- Remove RaftClientReply.getException since it is not used.
- In Raft.proto, remove {{message}} from ServerInformationReplyProto
- There is a white space change in RaftServerImpl.waitForReply.
- Change ServerInformationBaseTest to implement
MiniRaftCluster.Factory.Get<CLUSTER>
{code}
+public abstract class ServerInformationBaseTest<CLUSTER extends
MiniRaftCluster>
+ extends BaseTest
+ implements MiniRaftCluster.Factory.Get<CLUSTER> {
{code}
and the subclass to extends its FactoryGet.
{code}
+public class TestServerInformationWithSimulatedRpc
+ extends ServerInformationBaseTest<MiniRaftClusterWithSimulatedRpc>
+ implements MiniRaftClusterWithSimulatedRpc.FactoryGet {
}
{code}
> Add an RPC to get server information
> ------------------------------------
>
> Key: RATIS-104
> URL: https://issues.apache.org/jira/browse/RATIS-104
> Project: Ratis
> Issue Type: New Feature
> Reporter: Tsz Wo Nicholas Sze
> Assignee: Chen Liang
> Attachments: RATIS-104.001.patch
>
>
> We propose to add a getServerInfo RPC to get server information from a server.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
