[
https://issues.apache.org/jira/browse/RATIS-95?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16245025#comment-16245025
]
Tsz Wo Nicholas Sze commented on RATIS-95:
------------------------------------------
{{example/src/main/bin}} sounds since it won't confuse the users
- Let's use ls and do not hard code the file version.
{code}
ARTIFACT=`ls target/ratis-examples-*.jar`
{code}
- The script files need a license header.
- It is a good starting point to have
org.apache.ratis.examples.arithmetic.Runner as the main class. It probably is
better to have a class org.apache.ratis.examples.Runner to run all the examples
(so that it can choose which example to run). This can be done in this JIRA or
separately.
Thanks a lot, I am very excited about your patch.
> Executable Jar for the ratis examples
> -------------------------------------
>
> Key: RATIS-95
> URL: https://issues.apache.org/jira/browse/RATIS-95
> Project: Ratis
> Issue Type: Improvement
> Reporter: Elek, Marton
> Assignee: Elek, Marton
> Attachments: RATIS-95.wip.patch
>
>
> The current example project shows an example implementation of the base
> interfaces. I suggest to create simple CLI application for the test (just an
> additional class with main and argument parsing) to make it easier to
> demonstrate how a ratis cluster could be run.
> For example:
> {code}
> java -jar ratis-examples-uber.jar --port 2323 --id node2 --peers
> node3:localhost:4566,node1:localhost:3456
> {code}
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
