[ 
https://issues.apache.org/jira/browse/RATIS-113?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16248068#comment-16248068
 ] 

Tsz Wo Nicholas Sze commented on RATIS-113:
-------------------------------------------

The conf is a good idea!
- Let's call it
{code}
raft.client.async.outstanding-requests.max
{code}
and set the default to 100.
- In RaftClient.Builder, we need to initialize it.
{code}
//before the rename suggested above
    private int maxParallelRequest = 
RaftClientConfigKeys.Async.MAX_PARALLEL_REQUEST_DEFAULT;
{code}

- We should use 
[Semaphore|https://docs.oracle.com/javase/8/docs/api/java/util/concurrent/Semaphore.html]
 instead of ArrayBlockingQueue in RaftClientImpl.

Actually, how about implement the new conf in a separated JIRA?  This patch is 
already quite complicated.  :)


> Add Async send interface to RaftClient
> --------------------------------------
>
>                 Key: RATIS-113
>                 URL: https://issues.apache.org/jira/browse/RATIS-113
>             Project: Ratis
>          Issue Type: Bug
>            Reporter: Mukul Kumar Singh
>            Assignee: Lokesh Jain
>         Attachments: RATIS-113.001.patch, RATIS-113.002.patch
>
>
> Raft Client currently only has a sync interface, an sync interface is needed 
> for ozone



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Reply via email to